Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beat] Update mappings for APM Server aggregation metrics #5509

Merged
merged 6 commits into from
Mar 16, 2023
Merged

[beat] Update mappings for APM Server aggregation metrics #5509

merged 6 commits into from
Mar 16, 2023

Conversation

miltonhultgren
Copy link
Contributor

@miltonhultgren miltonhultgren commented Mar 10, 2023 •
edited
Loading

A recent PR changes the shape of the documents for some APM metrics, which caused a breakage since the mappings didn't work.
This PR expands the mappings to the new object shape.

@miltonhultgren miltonhultgren added Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services Integration:beat Beat labels Mar 10, 2023
@miltonhultgren miltonhultgren requested a review from a team as a code owner March 10, 2023 15:30
@miltonhultgren miltonhultgren self-assigned this Mar 10, 2023
@miltonhultgren
Copy link
Contributor Author

@elastic/apm-server This is in response to the changes introduced by elastic/apm-server#10330

The monitoring setup is complicated to say the least :)

@elasticmachine
Copy link

elasticmachine commented Mar 10, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-16T17:35:47.581+0000

  • Duration: 18 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 10, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 100.0% (6/6) 💚
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@miltonhultgren miltonhultgren force-pushed the align-beat-with-metricbeat-module branch from 7848422 to 53fc70a Compare March 14, 2023 11:39
@miltonhultgren miltonhultgren changed the title [beat] Align mappings with Metricbeat module [beat] Update mappings for aggregation.txmetrics Mar 16, 2023
@miltonhultgren miltonhultgren changed the title [beat] Update mappings for aggregation.txmetrics [beat] Update mappings for APM aggregation metrics Mar 16, 2023
@miltonhultgren miltonhultgren changed the title [beat] Update mappings for APM aggregation metrics [beat] Update mappings for APM Server aggregation metrics Mar 16, 2023
@miltonhultgren miltonhultgren merged commit 90d6879 into elastic:main Mar 16, 2023
@elasticmachine
Copy link

Package beat - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=beat

@simitt
Copy link
Contributor

simitt commented Mar 20, 2023 •
edited
Loading

Apologies for coming back to this late. @miltonhultgren are you backporting this to 8.7?

@miltonhultgren
Copy link
Contributor Author

@simitt No problem, last week was special! I decided to just fix up the failure by mapping the new fields (mostly because the Integrations require all existing fields to be mapped) but I'm happy to make further changes if your team want things done differently!

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@miltonhultgren @agithomas
[beat] Update mappings for APM Server aggregation metrics (elastic#5509)
ac2d870
@miltonhultgren miltonhultgren mentioned this pull request Mar 20, 2023
Closed
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@miltonhultgren @agithomas
[beat] Update mappings for APM Server aggregation metrics (elastic#5509)
da58c34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klacabane klacabane klacabane approved these changes

Assignees

@miltonhultgren miltonhultgren

Labels
Integration:beat Beat Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miltonhultgren @elasticmachine @simitt @klacabane